[EFR32] LWIP Options should only be set in lwipopts.h

project-chip / connectedhomeip

Matter (formerly Project CHIP) creates more connections between more objects, simplifying development for manufacturers and increasing compatibility for consumers, guided by the Connectivity Standards Alliance.

https://buildwithmatter.com

Apache License 2.0

7.53k stars 2.03k forks source link

[EFR32] LWIP Options should only be set in lwipopts.h #23346

Open mamehta opened 2 years ago

mamehta commented 2 years ago

Reproduction steps

1. BUILD.gn files of EFR32 project contain the setting of defines for LWIP Options - these should only be set in lwipopts.h, as per the feedback in the comments of this PR: https://github.com/project-chip/connectedhomeip/pull/23106
2.
3.
...

Platform

efr32

Platform Version(s)

1.0

Type

Platform validated

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

mamehta commented 1 year ago

This issue is still open. Adding a comment to prevent the stale-bot from closing it.