search

project-codeflare / codeflare-operator

Operator for installation and lifecycle management of CodeFlare distributed workload stack
Apache License 2.0
7 stars 45 forks source link

feat(GH): add check on operator image #545

Closed zdtsw closed 7 months ago

zdtsw commented 7 months ago

Issue link

to prevent PR with new image gets merged and cause other parties falling their daily tasks.

What changes have been made

Verification steps

Checks

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign christianzaccaria for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/project-codeflare/codeflare-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
astefanutti commented 7 months ago

/lgtm

Thanks!

astefanutti commented 7 months ago

@sutaakar WDYT?

sutaakar commented 7 months ago

I am considering better solution which will trigger image build automatically for a push event in ODH CFO repo. Will create a PR today.

sutaakar commented 7 months ago

This PR is replaced by https://github.com/opendatahub-io/codeflare-operator/pull/53 , which was pushed directly into the repository. Closing this PR.