Set target cluster name in status

project-codeflare / multi-cluster-app-dispatcher

Holistic job manager on Kubernetes

Apache License 2.0

109 stars 63 forks source link

Set target cluster name in status #603

Closed cwiklik closed 1 year ago

cwiklik commented 1 year ago

modify options.go to include a new flag externalDispatch which when set to true would direct dispatcher to use external plug-in to dispatch workloads
modify queuejob_controller_ex.go to optionally set targetClusterName field in status. The value for the field comes from Spec.SchedSpec.ClusterScheduling.Clusters which can contain zero or more comma separated clusterIds. If more than one clusterId is provided, the code will choose one at random.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign metalcycling for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-merge-robot commented 1 year ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

dmatch01 commented 1 year ago

@cwiklik: Transitiion this PR to our MCC branch. Suggest closing it?

cwiklik commented 1 year ago

work in progress, not ready