search

project-codeflare / multi-cluster-app-dispatcher

Holistic job manager on Kubernetes
Apache License 2.0
109 stars 63 forks source link

Update mcad kuberay example #617

Closed tedhtchang closed 1 year ago

tedhtchang commented 1 year ago

Issue link

closes #583

What changes have been made

Verification steps

Follow the instruction in the modified doc/usage/examples/kuberay/kuberay-mcad.md file

Checks

This PR should be updated with the issue /cc @anishasthana @kevin85421

openshift-ci[bot] commented 1 year ago

@tedhtchang: GitHub didn't allow me to request PR reviews from the following users: kevin85421.

Note that only project-codeflare members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/project-codeflare/multi-cluster-app-dispatcher/pull/617): ># Issue link >closes #583 > ># What changes have been made >- update doc/usage/examples/kuberay/kuberay-mcad.md >- update example appwrapper yaml > ># Verification steps >Follow the instruction in the modified `doc/usage/examples/kuberay/kuberay-mcad.md` file > >## Checks >- [ ] I've made sure the tests are passing. >- Testing Strategy > - [ ] Unit tests > - [x] Manual tests > - [ ] Testing is not required for this change > >This PR should be updated with the [issue](https://github.com/ray-project/kuberay/issues/1327) >/cc @anishasthana @kevin85421 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
asm582 commented 1 year ago

/lgtm

asm582 commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/OWNERS)~~ [asm582] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment