search

project-codeflare / multi-cluster-app-dispatcher

Holistic job manager on Kubernetes
Apache License 2.0
109 stars 63 forks source link

Add make target that simplifies build-push-deployment to cluster #639

Closed ChristianZaccaria closed 1 year ago

ChristianZaccaria commented 1 year ago

Issue link

Closes #638

What changes have been made

The easy-deploy make target can be used for building and pushing a custom image of MCAD and deploying it on your K8s cluster for development.

Verification steps

Example: make easy-deploy TAG=yourtag USERNAME=rh_ee_jdoe

Checks

VanillaSpoon commented 1 year ago

I like this :) Works as expected. Only nit I would have is easy-push to me would suggest a quick image build and push, but this also deploys. So maybe make easy-deploy or make easy-custom-deploy?

lgtm other than that but I'll leave it open for more feedback

ChristianZaccaria commented 1 year ago

I like this :) Works as expected. Only nit I would have is easy-push to me would suggest a quick image build and push, but this also deploys. So maybe make easy-deploy or make easy-custom-deploy?

lgtm other than that but I'll leave it open for more feedback

Yeah I agree, nice one thanks!

I guess make easy-deploy makes more sense as that is the end goal of this make target.

Fiona-Waters commented 1 year ago

I really like this too. Tested on an OSD cluster and it works as expected. You could possibly also add a section on the command here https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/doc/deploy/deployment.md or to the main readme. /lgtm

ChristianZaccaria commented 1 year ago

I really like this too. Tested on an OSD cluster and it works as expected. You could possibly also add a section on the command here https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/doc/deploy/deployment.md or to the main readme. /lgtm

That's a great idea! Thanks @Fiona-Waters. Will do asap

ChristianZaccaria commented 1 year ago

@Fiona-Waters I added documentation on the Readme (for quick deployment), and on the deployment doc. Let me know what you think :) Thanks!

Fiona-Waters commented 1 year ago

@Fiona-Waters I added documentation on the Readme (for quick deployment), and on the deployment doc. Let me know what you think :) Thanks!

Looks great! :) /lgtm

ChristianZaccaria commented 1 year ago

@anishasthana Hi, could we get this merged please? It's from last sprint :) [MCAD]

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, VanillaSpoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/OWNERS)~~ [anishasthana] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment