search

project-codeflare / multi-cluster-app-dispatcher

Holistic job manager on Kubernetes
Apache License 2.0
108 stars 63 forks source link

Evaluate the usage of the resourceName label in generic resources #671

Open ChristianZaccaria opened 1 year ago

ChristianZaccaria commented 1 year ago

WHY

The resourceName label in the generic resources seems to be set but not used.

WHAT

Investigate/Evaluate the usage of this label, and if nothing breaks after the removal of this label.

HOW

The label is found in this file: https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/b420be074f99799e55bc0e08a37d356e7fb78b00/pkg/controller/queuejobresources/genericresource/genericresource.go#L47

Related PRs

https://github.com/project-codeflare/multi-cluster-app-dispatcher/pull/652 https://github.com/project-codeflare/multi-cluster-app-dispatcher/pull/665