project-gen3sis / R-package

Repository of the R-packageGen3sis
https://project-gen3sis.github.io/R-package/
GNU General Public License v3.0
29 stars 9 forks source link

South America distances missing #50

Closed ohagen closed 3 years ago

ohagen commented 3 years ago

Impossible to follow the tutorial, since distances matrices are currently not provided with the package. Either provide a line in the vignette to compile these distances or use another landscape as example at the vignette

benj919 commented 3 years ago

isn't this the landscape over here? https://github.com/project-gen3sis/Simulations/tree/master/landscape/SouthAmerica/

ohagen commented 3 years ago

Yes, but not according to:

we set verbose to 0 to avoid a large console outputs of how the simulation is

developing

sim <- run_simulation(config = file.path(datapath, "config/config_southamerica.R"), landscape = file.path(datapath, "landscape"), output_directory = tempdir(), call_observer = 1, verbose = 0)

Called at introduction vignette.
Only according to the intro.

benj919 commented 3 years ago

Line. 67 - 75 in the introduction.rmd vignette explains the need to download and setup the landscape(s) and datapath variable (line 72 is hidden and was setup like this for local vignette generation iirc). Line 67 states "and set the correct datapath" -> it should be clearer that the datapath variable needs to be set by the user to point to the downloaded data.

ohagen commented 3 years ago

True! Was using intro from my installed 1.1 version and got questioned on the intro.html by someone learning gen3sis that missed that out. Including me and my bad memory. Thus the source of confusion, since we there we loaded with: datapath <- system.file(file.path("extdata", "SouthAmerica"), package = "gen3sis") Clossing issue. Thanks Benji!