search

project-gen3sis / R-package

Repository of the R-packageGen3sis
https://project-gen3sis.github.io/R-package/
GNU General Public License v3.0
29 stars 9 forks source link

Fix #54: add > before the closing fence to match the opening fence #55

Closed yihui closed 3 years ago

yihui commented 3 years ago

If the opening fence of a code chunk is >```, the closing fence should be the same.

More info: https://github.com/yihui/knitr/issues/2057

benj919 commented 3 years ago

Thank you for this fix and the pull request. We'll check it out and most probably merge it soon.

yihui commented 3 years ago

@ohagen If you don't mind, you may just merge this PR (to save you some time). Your commit 58a25e2 is not enough to fix the Github action error. You'll have to also apply my commit 1d67011 if you intend to fix #54 in your PR #52 instead.

yihui commented 3 years ago

Or I can also send this PR to the development branch, so you can merge it to that branch instead of master if you prefer.

ohagen commented 3 years ago

@yihui Thanks! Thank you. benji will merge your PR and roll back my changes. Thank you very much. The dev and master will be merged as well since we will then send a new package version to CRAN. Thanks again @yihui