CRAN complain for non-standard things in the check directory ... NOTE

[ohagen]

* checking for non-standard things in the check directory ... NOTE
Found the following files/directories:
  'examples_i386' 'examples_x64' 'gen3sis-Ex_i386.Rout'
  'gen3sis-Ex_x64.Rout' 'tests_i386' 'tests_x64'

The above happens when checking the package.

[benj919]

As far as I can see this is a problem with rhub/cran, not the package itself... They might just ignore it on a submission.

[florianhartig]

Is this when you check locally, or with winbuilder? If you get such a message on incoming, you will nearly certainly be asked to fix this.

[benj919]

From my discussion with Oskar these files don't show up when building and checking locally on windows (with --as-cran)

[ohagen]

they still appear! I will reopen the issue until it's fixed

[florianhartig]

Ok, when this doesn't show up when checked with https://win-builder.r-project.org/upload.aspx, it should be fine

[florianhartig]

So, for me, the CRAN checks break already with the vignette, at

# TOADD a plot of richenss over time
load(file.path(datapath, "output/config_rte/sgen3sis.RData"))
#get total richness per time interval
rt <- colSums(sgen3sis$geo_richness[,-c(1,2)], na.rm = T)
#plot
plot(rt, type='l')

are you sure that this is running through? Regardless, to fix this, first thing I would do is to get the CI running (see https://github.com/project-Gen3sis/R-package/issues/9), this will give you a good hint how things look on a clean system, and then we can take it from there.

[ohagen]

I will update the vignette. Never did CI, so happy to support you as you tell me.

[ohagen]

Vignette should be working now. I changed the output system but still had the old sgen3sis object on my package folder! Thanks for spotting this out. Should work now regarding the vignette. Let me know what I should do regarding the CI

[florianhartig]

So, I don't get any of these non-standard files in my tests. Are you still getting this?

[florianhartig]

I think this is something from your local computers - do you actually see these files? Have you tried just erasing them?

[benj919]

I don't get this, but I'm on Ubuntu. Initially those files only showed up when checking with R-devel iirc...

[florianhartig]

So, who exactly can reproduce this problem, and if someone can reproduce it, could you describe exactly the circumstances under which this occurs?

If no one can reproduce it, I guess we should close this!

[florianhartig]

Oskar, check again if #25 is solved, I expect that this will be gone

[ohagen]

25 is fixed. Thanks! Can we close this? What do you get on mac when checking on -as --CRAN?

[florianhartig]

In never got a problem. Will close, you can re-open if this is showing up in any of the tests