search

project-serum / serum-dex-ui

Example implementation of a UI for the Serum DEX
Other
356 stars 538 forks source link

Build fails with default code (without adding charts) #99

Closed askmike closed 3 years ago

askmike commented 3 years ago

We prefer to run the UI without adding trading view charts (for licensing reasons amongst others), recent versions don't seem to compile anymore. I am not sure if this intentional (the readme hints that adding charts is optional). When trying to compile we get:


$ REACT_APP_GIT_SHA=`git rev-parse --short HEAD` REACT_APP_GIT_DATE=`git log -1 --date=format:"%Y/%m/%d" --format="%ad"` craco build
Creating an optimized production build...
Failed to compile.

./src/components/TradingView/index.tsx
Cannot find file '../../charting_library' in './src/components/TradingView'.

error Command failed with exit code 1.```
armaniferrante commented 3 years ago

The charts are required now, and were added here https://github.com/project-serum/serum-dex-ui/pull/98. A PR to make them optional would be great.

askmike commented 3 years ago

Thanks, I documented this change for now (see #100). We will try to get this sorted for our fork asap.