project-viable / viable-virtual-lab

Simulation framework to provide a virtual lab experience to teach research
https://project-viable.github.io/viable-virtual-lab/export/VirtualLabExport.html
Other
1 stars 0 forks source link

Add "obvious" type annotations #198

Open harperstoeckle opened 1 month ago

harperstoeckle commented 1 month ago

We should add type annotations in places where there is a clear type. There are a few places where it's less obvious how to add types; in particular, groups are used to indicate that a certain functions are expected to be implemented. For example, anything in the Heatable group is expected to implement the heat function, and any code that wants to heat something will first check that the object is in the Heatable group, then call heat on it. This is problematic because there's not really any way to enforce that those functions exist. Any solution to this is non-trivial, so we will have to figure that out separately.

harperstoeckle commented 3 weeks ago

Closed. We are adding type annotations as we update the code, so this doesn't need to be an explicit task.

Drock54651 commented 3 weeks ago

Check this list for files where you added static typing to: