project8 / hercules

Python package for scripting our simulation workflows
1 stars 0 forks source link

Simplify configuration of the simulation length #22

Open MCFlowMace opened 3 years ago

MCFlowMace commented 3 years ago

At the moment the simulation length in Hercules has to be controlled with two parameters. There is the record_size parameter, which tells Locust how many samples should be simulated. Independent of that the trajectory length in Kassiopeia is controlled with the t_max parameter. That means, increasing the record_size only adds additional zero samples while increasing t_max does not add more samples. I propose that one should depend on the other for simplicity.

pslocum commented 3 years ago

This sounds like a good idea. There is also a third parameter called "event-spacing-samples" that is a delay to control the start time of an event.

On Thu, Apr 29, 2021 at 6:33 AM Florian Thomas @.***> wrote:

At the moment the simulation length in Hercules has to be controlled with two parameters. There is the record_size parameter, which tells Locust how many samples should be simulated. Independent of that the trajectory length in Kassiopeia is controlled with the t_max parameter. That means, increasing the record_size only adds additional zero samples while increasing t_max does not add more samples. I propose that one should depend on the other for simplicity.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/project8/hercules/issues/22, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVBRON6XRK5XALMZR2DUYTTLEYV5ANCNFSM43ZTYBOQ .