search

projectEndings / staticSearch

A codebase to support a pure JSON search engine requiring no backend for any XHTML5 document collection
https://endings.uvic.ca/staticSearch/docs/index.html
Mozilla Public License 2.0
51 stars 22 forks source link

Return of OOM #323

Open joeytakeda opened 1 month ago

joeytakeda commented 1 month ago

We've dealt with OOM errors before, most prominently documented here in #157 (which was closed and re-opened and then closed again). The last time it was closed we had resolved the issue in #172 by removing @fork='true' from the java calls. But it looks like @fork was added back because of security manager warnings in #247 .

I've just hit this again in a project. Trying to increase memory (as we suggest in the docs)

export ANT_OPTS="-Xmx6g"; ant

still causes the build to fail for this project with OOM issues on the json step after ~ 15 mins or so. However, removing @fork from the java call in json does not throw any SecurityManager issues for me and completes really quickly.

I'm wondering if the security manager issues are still relevant? If so, maybe we could add a fork property to the build so that users needing to fork the processes to access higher memory allocations can do so?

joeytakeda commented 1 month ago

May be useful to note that I am running ant 1.10.14, which is the version cited in this comment about these warnings:

https://bz.apache.org/bugzilla/show_bug.cgi?id=65381#c10

joeytakeda commented 3 weeks ago

Just tried the same on Jenkins and saw those security manager warnings. I think if I'm understanding things correctly, those security manager warnings derive from versions of Java < 18; ant 1.10.14 and above requires Java 18+; Jenkins uses Java 17, which is why there's an issue there.

martindholmes commented 2 weeks ago

Fix committed -- do we need to document this?