projectLEMDO / lemdoIssues

Repository for LEMDO issue tracking and related documents.
MIT License
1 stars 0 forks source link

Douai anthology page numbers go over pseudoelement for page beginnings #203

Closed LEMDO-PM closed 9 months ago

LEMDO-PM commented 10 months ago

The Douai anthology have styled their page numbers to be larger than they are on the LEMDO-dev site. This makes it so that the number overlaps with the pseudoelement for the next page beginning when there is no other content on that page:

image

We don't want these things to overlap, but like where the page numbers are in all other cases. Is it possible to make there be more white space between the two page beginning pseudoelements when the only thing in between them is the page number? In those situations, the HTML looks like this: <div data-el="pb"> <span data-el="fw" data-type="pageNum">132</span> </div>

I think that the spacing that we use for blank pages (shown in the image above) would work really well.

pszpak commented 9 months ago

Can you shoot me a link to a good example page?

LEMDO-PM commented 9 months ago

It's on the Douai dev site on the emdDouai_JC page. I'll send you a link in Teams.

pszpak commented 9 months ago

There are a few ways of doing this, but I the best way is using the existing css and modifying it in the douai.scss file that will then override lemdodev.scss. That means increasing the white space between div.page elements when span[data-el="fw" is within the div.page to accommodate the bigger page numbers.

@supports selector(:has(*)) body[data-catrefs*=letSemiDiplomatic] div.page:has(span[data-el=fw]) { margin-top: 3rem; margin-bottom: 2rem; }

Which renders like this:

Screenshot 2024-02-06 at 10 33 30 AM
LEMDO-PM commented 9 months ago

Oo great!! Thanks :)

LEMDO-PM commented 9 months ago

Fix looks good! Closing this now