projectLEMDO / lemdoIssues

Repository for LEMDO issue tracking and related documents.
MIT License
1 stars 0 forks source link

Rendering of in-line stage directions #269

Closed JackWilton1594 closed 2 months ago

JackWilton1594 commented 2 months ago

Hi team,

In-line stage directions are rendering in odd ways. Here, in 1HW, for example:

Screen Shot 2024-09-03 at 13 25 29

The stage directions should be rendered in brackets and on the same line as the dialogue. The code is: `

Hippolito
              <l part="I"><stage type="delivery" xml:id="emd1HW_M_a1_s1_sd4">To the Duke</stage> I do arrest thee, murderer.</l>
              <l part="F"><stage type="delivery" xml:id="emd1HW_M_a1_s1_sd5">To Attendants</stage> Set down,</l>
              <l><anchor xml:id="emd1HW_M_anc_4332"/>Villains, set down <anchor xml:id="emd1HW_M_anc_37"/>that sorrow<anchor xml:id="emd1HW_M_anc_38"/>; ’tis all mine<anchor xml:id="emd1HW_M_anc_4333"/>.</l>
           </sp>`

Two further examples:

Screen Shot 2024-09-03 at 13 25 42 Screen Shot 2024-09-03 at 13 25 48

martindholmes commented 2 months ago

The style file modernized.scss line 35 specifies that stage directions are by default display: block; stage directions which are direct children of the speech (<sp>) element are to be rendered inline. @LEMDO-PM @pszpak: is this the intended behaviour? Or was the intention that <stage> elements that are descendants of <sp> elements should be inline?

JackWilton1594 commented 2 months ago

Stage directions which are direct children of <l> or <p> within <sp> should be rendered inline. These are typically delivery (To X, Aside) and other stage business (Shakes, Rattles, and Rolls).

Stage directions outside of these – but still within <sp> – should have their own line. These include entrances, exits, and more complex stage business. These should be flush left, except for exits which are flush right. Example:

`

Somebody Blah blah blah. Somebody Else enters. Oh look, Somebody Else is here!

`

LEMDO-PM commented 2 months ago

I'll be on this tomorrow afternoon.

LEMDO-PM commented 2 months ago

I've committed a fix for this, and Martin has committed a fix for an XSLT issue to restore parentheses. Leaving this open for now, but will close once we see the new build.

LEMDO-PM commented 2 months ago
image
LEMDO-PM commented 2 months ago

This looks good in this last build. Closing this issue :)