search

projectatomic / commissaire-mvp

A lightweight REST interface for upgrading, restarting, and bootstrapping new hosts into an existing Container Management cluster.
http://commissaire.readthedocs.org/en/latest/
GNU General Public License v3.0
15 stars 9 forks source link

Model validation #171

Closed ashcrow closed 8 years ago

ashcrow commented 8 years ago

Requires https://github.com/projectatomic/commissaire/pull/169

rh-atomic-bot commented 8 years ago

:umbrella: The latest upstream changes (presumably efbbad8) made this pull request unmergeable. Please resolve the merge conflicts.

mbarnes commented 8 years ago

@ashcrow Can you rebase this on master? The previous PR is mixed in here.

mbarnes commented 8 years ago

Relevant commits look good. Out of curiosity, did you consider using jsonschema? It looks like it covers a lot of the same ground for JSON validation.

https://pypi.python.org/pypi/jsonschema

ashcrow commented 8 years ago

@ashcrow Can you rebase this on master? The previous PR is mixed in here.

Working on it now

In terms of jsonschema I did not. Might be worth migrating in the near future.

mbarnes commented 8 years ago

Travis still not happy today. Failing on a PicklingError but I don't think that's our code.

ashcrow commented 8 years ago

(2) [multi-host-mgr] Add model validation

mbarnes commented 8 years ago

Ran all tests locally and merged.