search

projectatomic / vagrant-service-manager

To provide the user a CLI to configure the ADB/CDK for different use cases and to provide glue between ADB/CDK and the user's developer environment.
GNU General Public License v2.0
18 stars 16 forks source link

Converted CHANGELOG from markdown to asciidoc #404

Closed thatdocslady closed 7 years ago

thatdocslady commented 7 years ago

Fix for issue #407

Related to issue 557 in main ADB repository: https://github.com/projectatomic/adb-atomic-developer-bundle/issues/557

This issue is a part of the overall asciidoc migration and aims to unify the format of all doc files to asciidoc.

centos-ci commented 7 years ago

Can one of the admins verify this patch?

LalatenduMohanty commented 7 years ago

LGTM

hferentschik commented 7 years ago

please test

thatdocslady commented 7 years ago

@hferentschik please test what?

hferentschik commented 7 years ago

@thatdocslady "please test" is a command to the CI instance. It is a response to the fact that you are not on the whitelist of people for whom the pull request are automatically validated.

hferentschik commented 7 years ago

add to whitelist

hferentschik commented 7 years ago

I do not think this matter much. As long as we are consistent and can communicate the time of release, we should be good.

+1 I don't think the markup language matters much here. What does matter though is to find a better format than just listing git commits. The changelog should be based on actual issues fixed and backed by milestones. Last but not least, we should generate it automatically. That's all on the roadmap thought ... ;-)

hferentschik commented 7 years ago

@thatdocslady that said, each pull request should have an underlying issue which allows us to track in in milestones and also generate a proper changelog further down the track. The commit message should then reference this issue.

I'll take care of this, this time around :-)

hferentschik commented 7 years ago

Created issue #407, adjusted commit message, rebased and merged :-)