search

projectatomic / vagrant-service-manager

To provide the user a CLI to configure the ADB/CDK for different use cases and to provide glue between ADB/CDK and the user's developer environment.
GNU General Public License v2.0
18 stars 16 forks source link

Service hooks doesn't start in vagrant reload #406

Closed coolbrg closed 8 years ago

coolbrg commented 8 years ago

It seems that the service hooks which are responsible to execute the services on vagrant up command doesn't work on vagrant reload command.

It may break the services if user doesn't use the shipped Vagrantfiles from ADB.

coolbrg commented 8 years ago

cc @LalatenduMohanty @hferentschik Let me know what do you think?

LalatenduMohanty commented 8 years ago

vagrant reload should work. Personally I do not use it much, so not aware of this issue.

LalatenduMohanty commented 8 years ago

@optak have you tested vagrant reload on ADB/CDK?

coolbrg commented 8 years ago

vagrant reload should work. Personally I do not use it much, so not aware of this issue.

It is working since services are starting through shell provisioners in shipped vagrantfiles. However, vagrant reload is a usual dev workflow.

hferentschik commented 8 years ago

vagrant reload should work. Personally I do not use it much, so not aware of this issue.

+1 Same here. I don't use it much, but the expectation is that it works.

@budhrg Can you describe/document what exactly is not working.

hferentschik commented 8 years ago

@budhrg Also, I believe that you tested this as part of the pull request #400 and HTTP proxy config settings. Does reload just not work with proxy settings, or does it generally not work.

coolbrg commented 8 years ago

Does reload just not work with proxy settings, or does it generally not work.

Vagrant reload doesn't work. However, shipped vagrantfiles just works since starting of services are done through shell provisioners.

coolbrg commented 8 years ago

If we use plain Vagrantfile as:

Vagrant.configure(2) do |config|
  config.vm.box = 'cdkv2'

  config.vm.provider "virtualbox" do |v, override|
    v.memory = 3072
    v.cpus   = 2
    v.customize ["modifyvm", :id, "--ioapic", "on"]
    v.customize ["modifyvm", :id, "--natdnshostresolver1", "on"]
  end

  config.servicemanager.services = "docker, openshift"
end

then the service openshift doesn't start on vagrant reload.

hferentschik commented 8 years ago

Then we have an issue. Let's find out what the problem is.

hferentschik commented 8 years ago

For what's worth, I just fixed the a vagrant reload issue for Landrush. There on reload, the DNS server was not restarted. The rub was not so much that the hooks were not executed, but more in the wrong order. On the reload, the startup hooks were running before the shutdown ones (not a bug mind you). This was based on the fact that in Vagrant one needs to think about up and down hooks (determined on when you call app.call in your action/hook). So the system was actually behaving as it was designed, but not necessarily how one would expect on initial thought.

I would not be surprised if we have a similar situation in service-manager.

coolbrg commented 8 years ago

@hferentschik Fix is on the way :)