Fix #446 Support folder as path in install-cli '--path' option

projectatomic / vagrant-service-manager

To provide the user a CLI to configure the ADB/CDK for different use cases and to provide glue between ADB/CDK and the user's developer environment.

GNU General Public License v2.0

18 stars 16 forks source link

Fix #446 Support folder as path in install-cli '--path' option #451

Closed coolbrg closed 7 years ago

coolbrg commented 7 years ago

Fix #446

praveenkumar commented 7 years ago

Only thing I am wondering whether this is something we should do now, given that we want to make minimal changes for the user.

I agree. This change is already tested out and passed CI so let's merge this and then we will not put any effort here.

LalatenduMohanty commented 7 years ago

Agree with @hferentschik , this is not a blocker and not planned for CDK 2.4 release. However we can merge this and take this for 2.4 as this has passed review and testing.

coolbrg commented 7 years ago

Agree with @hferentschik , this is not a blocker and not planned for CDK 2.4 release. However we can merge this and take this for 2.4 as this has passed review and testing.

:+1: