search

projectblacklight / blacklight-gallery

Gallery views for Blacklight
Other
14 stars 11 forks source link

Openseadragon fixes #159

Closed marlo-longley closed 1 month ago

marlo-longley commented 1 month ago

Closes #3178 This was tested as part of a Spotlight application.

Changes:

  1. the custom icons had stopped working because the ViewComponent was generating sequential ids (so 1-zoom-in 2-zoom-out) rather than using a consistent id for all control elements.

2. I wasn't able to get tests to pass without changes to the @presenter setup, which mimics the setup in the other ViewComponents.

  1. In testing this work I found that multi-page items were rendering incorrectly. It seems that the options/params expected by OSD have changed: I needed to add sequenceMode: true, and I was able to remove other options that were set by default. Before (goes to last page and is just broken): Screenshot 2024-10-09 at 3 45 02 PM

After:

Screenshot 2024-10-09 at 3 45 21 PM
marlo-longley commented 1 month ago

@jcoyne thank you for reviewing. I addressed your comments.