projectblacklight / blacklight

Blacklight provides a discovery interface for any Solr (http://lucene.apache.org/solr) index.
http://projectblacklight.org/
Other
760 stars 256 forks source link

Restore modal events that were dropped in Blacklight 8 #3408

Closed cbeer closed 1 month ago

cbeer commented 1 month ago

I understand why the bootstrap-triggered events were removed with the switch to HTML5-native modals, but I'm not sure why the loaded.blacklight.blacklight-modal. This was a very useful extension point for plugins and other applications, and requiring all of them to set up mutation observers (e.g https://github.com/projectblacklight/blacklight_range_limit/pull/249) isn't very satisfying.

I also added show + hide events (the <dialog> emits its own close event) to restore some other useful extension points too.