search

projectblacklight / blacklight_advanced_search

Advanced search plugin for Blacklight
http://projectblacklight.org
Other
24 stars 25 forks source link

Allow empty parens in a string to be safely parsed #122

Open dkinzer opened 1 year ago

dkinzer commented 1 year ago

This change allows an empty set of parens, (), to be in a string and to be parsed as a token. Prior to this change, and empty set of parens would be parsed as a list with no contents which could not be successfully parsed, but instead results in a error as described in #101.

This change fixes issue #101.

This is originally some work by @bibliotechy in this PR which I merged without rebasing and it had issues that needed to be fixed before it could be merged: #112

dkinzer commented 1 year ago

I cannot reproduce the issue locally using ruby version 3.1.2p20. I think this error is CI specific issue.