Use bundled `bootstrap.min.css`

projectnessie / nessie-ui

Nessie Web UI

3 stars 3 forks source link

Use bundled `bootstrap.min.css` #145

Closed tamarinkeisari closed 2 months ago

tamarinkeisari commented 3 months ago

Import Bootstrap CSS Locally

Description: This pull request modifies the project to import the Bootstrap CSS file directly from the node_modules directory, replacing the current dependency on the CDN link.

Summary of Changes This update addresses the feature request to enhance the project's ability to function in isolated environments without internet access by importing Bootstrap CSS locally. The following changes have been made:

Remove CDN Link
Local Bootstrap Import: Added an import statement for bootstrap.min.css in src/index.tsx.

we test it locally in it seems to run fine

Related issue: #144

CLAassistant commented 3 months ago

All committers have signed the CLA.

snazy commented 3 months ago

@tamarinkeisari thanks for the contribution! Looks like CI (build) is not happy with your change, can you take a look?

tamarinkeisari commented 2 months ago

Hi, @snazy The ESlint is configured with the import/no-internal-modules option which prevents importing the bootstrap min css from the node modules. Should we add an eslint ignore on the import?

snazy commented 2 months ago

The ESlint is configured with the import/no-internal-modules option which prevents importing the bootstrap min css from the node modules. Should we add an eslint ignore on the import?

Works for me. But only for that file.

tamarinkeisari commented 2 months ago

I disabled the eslint rule for that import line like we discussed

snazy commented 2 months ago

Can you also fix the 2nd build issue?

tamarinkeisari commented 2 months ago

Hi, after I run npm run lint the build works, but the linting changes a lot of files in the project that are not related to the PR. Do you want me to upload these unrelated fixes?

snazy commented 2 months ago

@tamarinkeisari only the one that lets CI fail

tamarinkeisari commented 2 months ago

I uploaded the fix, please let me know if there is anything else to do?

snazy commented 2 months ago

Looks like you haven't signed the CLA yet.

tamarinkeisari commented 2 months ago

Signed :)

snazy commented 2 months ago

@tamarinkeisari sorry, we not be able include this change in Nessie yet. There's something odd there.

I'm not sure whether it's your change or something else. The UI looks different.

Previous nessie-ui release 0.63.6:

0.64.0:

snazy commented 2 months ago

Can confirm - it's from your change.

nessie-ui from commit 4d132d9096f6c06cbfc84174bc758be10e968ae1 looks fine: