projectsyn / component-prometheus

Commodore component to wrap kube-prometheus jsonnet library.
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Custom Prometheus version is ignored #99

Closed mhutter closed 1 month ago

mhutter commented 1 month ago

No matter the version configured, the Prometheus image will always be the same: quay.io/prometheus/prometheus:v2.29.1.

Steps to Reproduce the Problem

Given this configuration

parameters:
  prometheus:
    instances:
      some:
        prometheus:
          enabled: true
          config:
            version: v1.33.7

Actual Behavior

apiVersion: monitoring.coreos.com/v1
kind: Prometheus
# ...
spec:
  image: quay.io/prometheus/prometheus:v2.29.1
  version: v1.33.7
# ...

Expected Behavior

apiVersion: monitoring.coreos.com/v1
kind: Prometheus
# ...
spec:
  image: quay.io/prometheus/prometheus:v1.33.7
  version: v1.33.7
# ...
mhutter commented 1 month ago

Turned out to be PEBCAK. Instead:

parameters:
  prometheus:
    instances:
      some:
        common:
          versions:
            prometheus: 1.33.7

This is the way.