Add support for FreeBSD

projg2 / cpuid2cpuflags

Tool to generate CPU_FLAGS_* for your CPU

GNU General Public License v2.0

104 stars 20 forks source link

Add support for FreeBSD #19

Closed danfe closed 2 years ago

danfe commented 2 years ago

I've played with it on ARM today and it seems to work. Two changes were required:

Replace getauxval(3), a non-standard glibc extension, with our native elf_aux_info(3) call
Return features supported by the specific machine processor architecture rather than the hardware platform, because the latter is too vague on FreeBSD: it always returns just arm without any version (generation)

The actual patch is here.

mgorny commented 2 years ago

Do you have anything against submitting that as a PR?

danfe commented 2 years ago

Do you have anything against submitting that as a PR?

Well, I don't really like them (nor was I sure if you'd like the patch in the first place), but owing to your reputation and politeness, I will. :-)

mgorny commented 2 years ago

Thanks. I'll probably request some changes, if you don't mind me, though. If you do, I can take it from there — or you can just mail me the patch, my main concern is just want to get the attribution right.

danfe commented 2 years ago

I'll probably request some changes, if you don't mind me, though.

Understood (and expected). I don't mind, let's resolve this to mutual happiness.

danfe commented 2 years ago

Fixed with 9d1b472, closing.