search

prolificinteractive / Caishen

A Payment Card UI & Validator for iOS
MIT License
766 stars 119 forks source link

Removed automated formatting of placeholder text to avoid crashes #97

Closed DannyVancura closed 8 years ago

DannyVancura commented 8 years ago

Fixes #95

This removes formatting numeric placeholders (such as 4321432143214321 to 4321 4321 4321 4321) which can currently cause runtime crashes. Doing this on the user side most likely makes more sense (giving user full control about what to format in which way) and removing it might make the Pod itself more stable and easier to maintain.

ppatriotis commented 8 years ago

Do we need to add instructions for developers about how to format the placeholders if it is needed?

DannyVancura commented 8 years ago

Good point, the readme currently says this about the placeholder: "The card number place holder. This will be automatically formatted at runtime to look like an actual Visa card number." I'll update it there to include this information.