search

prologin / concours-site

Source code of the Prologin contest website
https://gitlab.com/prologin/concours/site
GNU General Public License v3.0
10 stars 6 forks source link

user: fix user's birthday can be future #331

Closed Nhqml closed 2 years ago

Nhqml commented 3 years ago

Fix #327

Apply @lportemo's feedback from #329

codecov[bot] commented 3 years ago

Codecov Report

Merging #331 (acc1cd6) into master (a96f0c8) will increase coverage by 0.01%. The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   51.43%   51.45%   +0.01%     
==========================================
  Files         198      199       +1     
  Lines        9680     9688       +8     
==========================================
+ Hits         4979     4985       +6     
- Misses       4701     4703       +2
Impacted Files Coverage Δ
prologin/users/models.py 69.89% <66.66%> (-0.39%) :arrow_down:
...ologin/users/migrations/0008_auto_20210211_2255.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a96f0c8...d1bd72a. Read the comment docs.

Elfikurr commented 3 years ago

I believe that this should be done anywhere you want. But adding a message saying the date of birth will be used for the rest of the contest could be good !

Max1Truc commented 2 years ago

Was this PR merged ?

Max1Truc commented 2 years ago

I can resolve the conflicts and create a new PR if needed.

Nhqml commented 2 years ago

I can resolve the conflicts and create a new PR if needed.

I believe there is no need to create a new branch/PR, you can work on this one.

@lportemo is it OK with you?

Max1Truc commented 2 years ago

@lportemo

juli0z commented 2 years ago

Migrated to https://gitlab.com/prologin/concours/site/-/merge_requests/331