prologin / concours-site

Source code of the Prologin contest website
https://gitlab.com/prologin/concours/site
GNU General Public License v3.0
10 stars 6 forks source link

PROLOGIN_SEMIFINAL_MIN_WISH_COUNT = 0 is ignored in ContestantCompleteSemifinalManager #333

Closed lportemo closed 2 years ago

lportemo commented 3 years ago

https://github.com/prologin/site/blob/a96f0c8e7256ed3ef77ec0d47155777caf5a9f76/prologin/contest/models.py#L172

This line filters out contestants that have no wish even if PROLOGIN_SEMIFINAL_MIN_WISH_COUNT is set to 0.

We should modify the query or indicate that PROLOGIN_SEMIFINAL_WISH_COUNT cannot be equal to 0

juli0z commented 2 years ago

Migrated to https://gitlab.com/prologin/concours/site/-/issues/333