Closed TheoHollender closed 2 years ago
TheoHollender
commented
3 years ago One possible Bug in the Program : let's assume we have two forums, a forum contains an id, a name and a slug, the program only takes the slug to get the forum, if there are two forums with the same slugs but not the same id, a bug might appear.
TheoHollender
commented
3 years ago Bug of Forum with same Names fixed, I modified the entire search according to Elfikur's request, when you press Enter in the text box to search, it will send you on a page of this form "/forum/search/forum-slug-id?q=Your query" and will show all the pages which have been requested on the page number 1. There is also a variable of the ForumSearchSuggestView called context_query_render_type, which is a boolean and if True the query will be written in the text box but if false there will be a text below the search bar. Possible bug that I will fix is to verify whether the form of the url is correct cause for the moment, if there is no query/no ?q=, redirect to the "/forum/forum-slug-id"
lportemo
commented
3 years ago @MrThimote : you may remove the zinnia migration. It seems good to me. I'll be testing this on a dev environment soon before merging it. Thanks for your work and your quick responses to this PR :)
TheoHollender
commented
3 years ago ok i just have a question how do i remove this file do i just delete it and push again and this will work or do i need to do something special so that it works?
lportemo
commented
3 years ago You just need to delete the file, git add the deleted file , git commit and git push 🙂
TheoHollender
commented
3 years ago Ok, thank you
juli0z
commented
2 years ago
Search for a special Thread in a Forum by name https://github.com/prologin/site/issues/341
Might need some adjustement on CSS