prologin / concours-site

Source code of the Prologin contest website
https://gitlab.com/prologin/concours/site
GNU General Public License v3.0
10 stars 6 forks source link

Added Instagram and Discord social links to footer #359

Closed laggron42 closed 2 years ago

laggron42 commented 2 years ago

Modified the footer to add Prologin's Instagram page and Discord server.

Font Awesome 4 doesn't have Discord so we added their SVG with custom CSS.

Resolves #354

codecov[bot] commented 2 years ago

Codecov Report

Merging #359 (f611b69) into master (44cb236) will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
- Coverage   51.53%   51.51%   -0.03%     
==========================================
  Files         202      202              
  Lines        9652     9658       +6     
==========================================
+ Hits         4974     4975       +1     
- Misses       4678     4683       +5     
Impacted Files Coverage Δ
prologin/archives/thirdparty/vimeo.py 37.14% <0.00%> (-1.10%) :arrow_down:
prologin/prologin/utils/scoring.py 20.40% <0.00%> (-0.43%) :arrow_down:
prologin/prologin/management/commands/edition.py 0.00% <0.00%> (ø)
...rologin/management/commands/migrate_from_drupal.py 0.00% <0.00%> (ø)
...mifinal/management/commands/semifinal_bootstrap.py 0.00% <0.00%> (ø)
prologin/contest/widgets.py 52.50% <0.00%> (+1.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44cb236...f611b69. Read the comment docs.

e-n-0 commented 2 years ago

Why don't use the fa-discord icon from Font Awesome like other social networks in the list?

lportemo commented 2 years ago

The site uses font-awesome version 4. Last time I checked, there was no fa-discord on font-awesome 4.

If you want, you can migrate the whole site to font-awesome >=5 (what a funny job)

juli0z commented 2 years ago

Migrated to https://gitlab.com/prologin/concours/site/-/merge_requests/359