search

prologin / concours-site

Source code of the Prologin contest website
https://gitlab.com/prologin/concours/site
GNU General Public License v3.0
10 stars 6 forks source link

contest: fix broken event wish order #367

Closed lportemo closed 2 years ago

lportemo commented 2 years ago

adminsortable's SortableMixin was trafficking the order of event wishes before the save as a result, two event wished could have the same order (i.e 1, 1, 2). Now the order of the wishes are (0, 1, 2).

Removed the admin sortable from contest eventwish as it is no longer maintained. Instead use raw order field to modify event wish order in django admin.

codecov[bot] commented 2 years ago

Codecov Report

Merging #367 (c8ba818) into master (7294ecf) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   51.51%   51.52%   +0.01%     
==========================================
  Files         202      202              
  Lines        9658     9652       -6     
==========================================
- Hits         4975     4973       -2     
+ Misses       4683     4679       -4
Impacted Files Coverage Δ
prologin/contest/admin.py 84.00% <100.00%> (+3.75%) :arrow_up:
prologin/contest/models.py 60.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7294ecf...c8ba818. Read the comment docs.