prometheus-community / node-exporter-textfile-collector-scripts

Scripts for node-exporter's textfile collector
Apache License 2.0
512 stars 191 forks source link

Remove smartmon run metric #152

Closed SuperQ closed 1 year ago

SuperQ commented 1 year ago

This metric is a bit funny, it's a timestamp per device, but it's not accurate enough (seconds, not milliseconds) to derive much useful information from it. This should probably be replaced with a per-device duration metric.

dswarbrick commented 1 year ago

Is this related to my necropost on #104? ;-)

Personally I don't know what the point of this metric is, and the help text is equally vague. If the original author wanted timestamps of when the metrics were actually collected for the device, this is not the right way to go about it.

I suspect they were unaware that the Prometheus text exposition format allows optional timestamps as the last field on the line.

SuperQ commented 1 year ago

Yes, but we forbid timestamps on textfile collector metrics. And there's already a node_exporter mtime metric for when the last textfile was updated.

dswarbrick commented 1 year ago

I was not aware that timestamps are forbidden on textfile collector metrics. I suspect I probably attempted to use them on the odd occasion in the past.

In any case, I don't see that this smartctl_run metric adds anything of significant value that cannot be derived from node_textfile_mtime_seconds, and I agree that a per-device collection duration would be more useful.