search

prometheus-community / node-exporter-textfile-collector-scripts

Scripts for node-exporter's textfile collector
Apache License 2.0
512 stars 191 forks source link

lvm: add support for "all" checks #160

Closed anarcat closed 1 year ago

anarcat commented 1 year ago

It seems rather inconvenient to have to specify all those switches by hand. Right now, I need to specify -gpst to get all the stats and, if some new metric get added (e.g. #159 hopefully), I need to remember to update my callers to match. This is annoying.

Let's make a -a that's going to do it all for us. Hell, i'd make it the default, personally, if I wasn't worried about breaking people's stuff...

This obviously conflicts with other PRs that might add another flag like this, like #159. Please prioritize the latter.

SuperQ commented 1 year ago

Oh, oops, can you followup to this by adding -a to the usage text?

anarcat commented 1 year ago

The only issue with -a as default is there's no false switch on these. So there would be no way to turn them off.

i guess that the default would be all unless one of the flags is specified, in which case only the ones specific trigger...

anarcat commented 1 year ago

Oh, oops, can you followup to this by adding -a to the usage text?

fixed in #161