prometheus-community / node-exporter-textfile-collector-scripts

Scripts for node-exporter's textfile collector
Apache License 2.0
512 stars 191 forks source link

Script to create text file for hp ssacli tool output #162

Closed epwickey closed 1 year ago

epwickey commented 1 year ago

This is a script for creating text file with output from hp ssacli tool to monitor hp raids

dswarbrick commented 1 year ago

Are you aware that there is a dedicated https://github.com/sahandhabibi/Ssacli-Exporter?

epwickey commented 1 year ago

Are you aware that there is a dedicated https://github.com/sahandhabibi/Ssacli-Exporter?

I am. However since I had to create this since we already use node-exporter I thought I will contribute. Also the exporter only works for servers with one slot and only export physical disk metrics while this script can collect metrics for servers with multiple slots and it also collects metrics about the virtual disks and controller.

dswarbrick commented 1 year ago

The shellcheck errors will need to be fixed before this can be considered.

dswarbrick commented 1 year ago

Please proof read the script for style. I see a lot of inconsistent whitespace, e.g. double spaces between keywords, no space after semicolons, different indentation widths, etc.