search

prometheus-community / stackdriver_exporter

Google Stackdriver Prometheus exporter
Apache License 2.0
254 stars 97 forks source link

Replace comma-delimited string flags with repeatable flags #355

Open tommyzli opened 1 month ago

tommyzli commented 1 month ago

Closes https://github.com/prometheus-community/stackdriver_exporter/issues/44 The original issue is pretty old but the feature request still holds up, I too find it more ergonomic to manage repeatable flags rather than a large comma-delimited string. As suggested in the issue, I also changed metrics-type-prefixes to just metrics-prefixes

SuperQ commented 2 weeks ago

I like it, mind doing a rebase?

tommyzli commented 2 weeks ago

@SuperQ Done, thanks

SuperQ commented 1 week ago

I wonder if it would be worth keeping the original flag as-is, and append the strings.Split() to the new flag results. Then mark the original flag as deprecated and print a warning in the log.