IONOS cloud pagination - Githubissues

roidelapluie commented 2 years ago

The IONOS cloud integration does not use pagination, limiting to 1000 the number of servers discovered per datacenter.

We should integrate pagination in case a user has more than 1000 servers.

oceakun commented 1 month ago

Hi @roidelapluie! I'd like to take this up, if nobody is working on it.

Is there anything else I should know besides going through the IONOS docs?

bboreham commented 3 weeks ago

@oceakun go ahead! I suspect that making tests will be the hard part.

oceakun commented 1 week ago

Hi @bboreham, yes, updating the test took some time.

Though I have raised a PR for this, if you could please review it.

PS: The high diff is mainly due to the large test data

Also, I'd appreciate your opinion on how I should go about passing the checks as I'm not sure

why a majority of them aren't running, while being stuck at "Expected — Waiting for status to be reported" and
why netlify-related checks are failing, since I only made changes in the discovery/ionos directory, and the output exported (discovered servers, with pagination) only changes in length, which I think should not affect the frontend or its deployment.

prometheus / prometheus