search

prometheusresearch-archive / react-forms

Forms library for React.
1.16k stars 112 forks source link

note while updating immupdate #126

Closed bsr203 closed 8 years ago

bsr203 commented 8 years ago

Hi,

I use a custom build of this package and was using latest of all dependencies. There was a behavior change of an API on immupdate package. I spent some time hunting it down, and hope it saves some for you.

import update, { updateKey } from 'immupdate';

update now takes an object, and old behavior can be achieved with updateKey. So, in Value.js, we need to use updateKey instead of update.

Cheers.

andreypopp commented 8 years ago

Awesome. Thanks, will fix that after I come back from vacation.

On Wed, Mar 2, 2016, 22:24 bsr203 notifications@github.com wrote:

Hi,

I use a custom build of this package and was using latest of all dependencies. There was a behavior change of an API on immupdate package. I spent some time hunting it down, and hope it saves some for you.

import update, { updateKey } from 'immupdate';

update now takes an object, and old behavior can be achieved with updateKey. So, in Value.js, we need to use updateKey instead of update.

Cheers.

— Reply to this email directly or view it on GitHub https://github.com/prometheusresearch/react-forms/issues/126.

krizka commented 8 years ago

Thanks for mention in, @bsr203 . I'm trying to make a simple date component and onChange returning empty object instead of date now.

krizka commented 8 years ago

Hm. It's not related to date, will add another issue

bsr203 commented 8 years ago

available in https://github.com/prometheusresearch/react-forms/pull/135/commits/3fe3709f445bfd789451c9ec0f1089c25baedc6a

andreypopp commented 8 years ago

We've got rid of immupdate entirely.