Combine `Subscription->get_meta()` and `Payment->get_meta()`

pronamic / wp-pronamic-pay

The Pronamic Pay plugin allows you to easily accept payments with payment methods like credit card, iDEAL, Bancontact and Sofort through a variety of payment providers on your WordPress website.

https://pronamicpay.com

34 stars 14 forks source link

Combine `Subscription->get_meta()` and `Payment->get_meta()` #236

Closed remcotolsma closed 2 years ago

remcotolsma commented 2 years ago

Meta key prefix _pronamic_payment_ and _pronamic_subscription_.

rvdsteege commented 2 years ago

In https://github.com/pronamic/wp-pay-core/commit/d831f2cf2aacdb5fbaf67e032015f6baab74b782:

added the meta key prefixes;
removed methods $subscription->get_meta() and $subscription->set_meta().

PaymentInfo::set_meta( ... ) needs some attention, as it still updates/deletes post meta.

rvdsteege commented 2 years ago

@remcotolsma is https://github.com/pronamic/wp-pay-core/commit/921d838e55bcfe5f929398f74f4fa1d182ce4742 correct or am I missing something?