prooph / event-store-http-api

Prooph EventStore HTTP API
http://getprooph.org/
BSD 3-Clause "New" or "Revised" License
18 stars 3 forks source link

Bugfixes and Improvements #23

Closed prolic closed 7 years ago

prolic commented 7 years ago

resolves https://github.com/prooph/event-store-http-api/issues/22

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 3764f03a87f6272277c09703a4216244309e21c3 on integration_tests into 5fd2534f0f5b08f10567c9b265680a60110be46e on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling bc7699337790a06faf71084322c51f0354e1782e on integration_tests into 5fd2534f0f5b08f10567c9b265680a60110be46e on master.

prolic commented 7 years ago

I sometimes receive this:

1) ProophTest\EventStore\Http\Api\Integration\FetchStreamNamesTest::it_fetches_stream_names

Http\Client\Exception\NetworkException: cURL error 7: Failed to connect to localhost port 8080: Connection refused (see http://curl.haxx.se/libcurl/c/libcurl-errors.html)

This happens only during integration tests. I already increased the sleep time after server start, but didn't help.

Note: On my machine I don't need sleep at all, it works perfectly fine without it.

Ideas?

ping @codeliner

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 42eddf2201fa0ba0b3c682fa8c01a7bcaa238dd1 on integration_tests into 5fd2534f0f5b08f10567c9b265680a60110be46e on master.

codeliner commented 7 years ago

No idea, really looks like a timing problem. Restarted the build and it is green now. Merge now. We can check the problem with the next PR or so :D