search

prooph / event-store-http-api

Prooph EventStore HTTP API
http://getprooph.org/
BSD 3-Clause "New" or "Revised" License
18 stars 3 forks source link

improvements #24

Closed prolic closed 7 years ago

prolic commented 7 years ago
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 60c5b7087659c0c11bac0afbf0318f8666eeea89 on improvements into 09019bbecca6ddfa82a22028c3a09dd8defce27d on master.

prolic commented 7 years ago

On my machine is works even without sleep. It's also only for testing.

On Jul 3, 2017 7:51 PM, "Bradley Weston" notifications@github.com wrote:

@bweston92 commented on this pull request.

In tests/integration/AbstractHttpApiServerTestCase.php https://github.com/prooph/event-store-http-api/pull/24#discussion_r125271258 :

@@ -72,14 +72,13 @@ protected function setUp(): void $this->client = new Client();

     // wait for server to start
  • usleep(200000);
  • usleep(100000);

What do yo think about actually testing, obviously if on an overloaded server 100ms might be a little touchy.

https://gist.github.com/bweston92/e31d35229499b3fa5b0f9cea95a93f d7#file-test_socket_to_stop_risky_test-php-L44-L58

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/prooph/event-store-http-api/pull/24#discussion_r125271258, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYEvKtKPGp5Qmp5lHi9aY8XIp1OtUzvks5sKNW3gaJpZM4OMKmU .