search

prooph / event-store-http-api

Prooph EventStore HTTP API
http://getprooph.org/
BSD 3-Clause "New" or "Revised" License
18 stars 3 forks source link

Integration Tests #25

Closed prolic closed 7 years ago

prolic commented 7 years ago

/cc @bweston92

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 9bf97f3a54ff9d66f0d4916312ad70a4d1cd2319 on integration into 1ff3b3b150bf59529c5451d840643959d98ebbf3 on master.

bweston92 commented 7 years ago

LGTM - conversation regarding the PR is below.

Bradley Weston @bweston92 13:20 @prolic is there BC breaks allowed in event-store-http-api? Obviously there is a beta out but is it ok to break

Sascha-Oliver Prolic @prolic 13:20 @bweston92 yes, it's not yet final release

Bradley Weston @bweston92 13:21 Ok was just going to say links it now _links

Sascha-Oliver Prolic @prolic 13:21 yes was wrong in first implementation

Bradley Weston @bweston92 13:23 @prolic FetchStreamNamesRegex could that be a way to exploit the system? I've head of dodgy regex's before which will cause a high cpu load

Sascha-Oliver Prolic @prolic 13:24 @bweston92 the api shouldn't be exposed to public normally