search

proper-testing / proper

PropEr: a QuickCheck-inspired property-based testing tool for Erlang
http://proper-testing.github.io
GNU General Public License v3.0
882 stars 167 forks source link

Some cleanups in the parallel code #275

Closed kostis closed 3 years ago

kostis commented 3 years ago

There is also a place where a type error exists - @pablocostass please take a look

pablocostass commented 3 years ago

Yep, I don't remember at which point I wrongly mistyped samples, but the match clause from line 2202 to 2206 (in your PR) can be removed. We can always concatenate the samples since most of the time we do not have anything in there, and even if we do it should not be costly (they would not be really really long lists).

Otherwise, feel free to change the match in L2202 to

 {worker_msg, #pass{performed = PassedRcvd, samples = []}, From, Id} ->
kostis commented 3 years ago

Let us discuss the issue a bit, once you have some time.