proper-testing / proper

PropEr: a QuickCheck-inspired property-based testing tool for Erlang
http://proper-testing.github.io
GNU General Public License v3.0
882 stars 167 forks source link

Substitute uses of `slave` with `peer` #293

Closed kostis closed 2 years ago

kostis commented 2 years ago

Erlang/OTP 25.0 introduces the following warnings about the slave module becoming deprecated in two years:

proper.erl:2407:10: Warning: slave:start_link/2 is deprecated and will be removed in OTP 27; use the 'peer' module instead
% 2407|     case slave:start_link(HostName, SlaveName) of

proper.erl:2479:64: Warning: slave:stop/1 is deprecated and will be removed in OTP 27; use the 'peer' module instead
% 2479|             StopFun = fun({Node, {already_running, false}}) -> slave:stop(Node);

Thus, I am creating this issue, which obviously is not urgent (esp. since PropEr still supports Erlang/OTP versions where the peer module is not present) so that somebody looks into this. @pablocostass perhaps?

pablocostass commented 2 years ago

Hey @kostis, I will gladly take a look at this this week, I knew this was bound to happen at some point. I seem to remember that the new peer module introduced in OTP25 has a bit of a different API than the deprecated module had, but it should not require many changes :)