search

protocolbuffers / protobuf-javascript

BSD 3-Clause "New" or "Revised" License
375 stars 67 forks source link

TypeError: reader.skipField is not a function #141

Closed TA2k closed 2 years ago

TA2k commented 2 years ago

Since 3.21.1 I receive TypeError: reader.skipField is not a function

on deserializeBinary(data).toObject()

with 3.21.0 it is working

Node 16.17.1

Nihcep commented 2 years ago

Same with reader.readUint64String is not a function Working with 3.21.0

dibenede commented 2 years ago

This definitely looks like the closure optimizations taking out too much. In the deeper details, all of our tests pass closure deps side, but it looks like our jasmine config for commonjs doesn't include most of our binary/ tests.

dibenede commented 2 years ago

I just published a hotfix release (3.21.2) to npm and will close this out now. Please re-open and ping me if the problem persists.