Inconsistency between the spec and implementation.

proxy-wasm / spec

WebAssembly for Proxies (ABI specification)

Apache License 2.0

544 stars 27 forks source link

Inconsistency between the spec and implementation. #36

Closed butterunderflow closed 1 year ago

butterunderflow commented 2 years ago

Hello, I'm a newcomer to proxy-wasm.

It seems there has been some inconsistency between the spec and implementation. For example, the host interface proxy_get_map_value is not used in Go SDK nor Rust SDK, they use proxy_get_header_map_value instead. For example.

Is this intentional or is it a choice of implementations?

codefromthecrypt commented 1 year ago

ran into another one today: proxy_send_http_response here, but proxy_send_local_response in the impls. For example, https://github.com/proxy-wasm/proxy-wasm-cpp-host/blob/d32cb05cb666216db5e1a383c1ffa2c1aeec19bb/include/proxy-wasm/wasm_api_impl.h#L98

mathetake commented 1 year ago

I am closing this issue, but please refer to https://github.com/proxy-wasm/spec/pull/39#issuecomment-1577876577 for the context!