search

prscX / react-native-bottom-action-sheet

React Native: Native Bottom Action Sheet
Apache License 2.0
634 stars 48 forks source link

remove immutable #10

Closed vonovak closed 6 years ago

vonovak commented 6 years ago

I do not use immutable, but judging by the docs, it seems to me that it can be replaced by built-in functionality of PureComponent and the dependency is thus not needed.

prscX commented 6 years ago

Many Thanks @vonovak for the PR.

I have reviewed and released V0.0.8. You can now install latest version and use the same.

Let me know in case you face any issues.

Thanks </ Pranav >

vonovak commented 6 years ago

@prscX Thanks! I noticed that the commit history is now "polluted" with intermediate commits from my work. I suggest you "squash and merge" the commits on PRs, it will make the project history nicer.

prscX commented 6 years ago

Thanks @vonovak for the valuable suggestion. Next time I will keep this in mind while merging 😄

Thanks </ Pranav >