prscX / react-native-bottom-action-sheet

React Native: Native Bottom Action Sheet
Apache License 2.0
634 stars 48 forks source link

onCancel handler never call on Android when swipe down GridView or SheetView #43

Closed retyui closed 5 years ago

retyui commented 5 years ago

Platform: Android RN: 0.59.0 react-native-bottom-action-sheet: 0.0.20

Example:

SheetView.Show({
      title: 'CHOOSE AN ACTION',
      items: [
        {
          title: 'Camera',
          value: 'camera',
        },
        {
          title: 'Files',
          value: 'gallery',
        },
      ],
      onSelection: (index, value) => { console.log("selection: " + index + " " + value); },
      // never  called when swipe down SheetView
      onCancel: () => console.log('Closing the bottom SheetView!!!') 
    });
retyui commented 5 years ago

How can I see in npm no these changes:

https://github.com/prscX/react-native-bottom-action-sheet/blob/dc1757a8ae9c9013d0680ead4dafc673ce0ccd5c/js/SheetView.js#L88-L94

https://unpkg.com/react-native-bottom-action-sheet@0.0.20/js/SheetView.js

image