search

prscX / react-native-bottom-action-sheet

React Native: Native Bottom Action Sheet
Apache License 2.0
634 stars 48 forks source link

Bugs on android 4.4.2 #7

Closed arma7x closed 6 years ago

arma7x commented 6 years ago

Icon does not appear in release build but works properly in debug. itemTintColor & itemTextColor doesn't works on android. I can only change backgroundColor

prscX commented 6 years ago

[+] @danielang

Thanks @arma7x for raising the issue.

Looks like it is similar to react-native-popover-menu: issue-11.

I have done a detailed research for issue-11 but I was not able to find the right solution. Basically in native we receive image url which is working as excepted in debug mode but on production it is not able to find the image.

One of the possible workaround I was thinking was to migrate to react-native-vector-icons. Doing this we will only be able to show icons provided by this library. Please let me know your views for the same.

Thanks Pranav

prscX commented 6 years ago

Hi @arma7x, I have enabled the support for react-native-vector-icons, now you will be able to integrate and use their icons. Please follow README in order to use the same.

Can you please install latest version and verify the same. Please let me know in case you face any issues.

Thanks Pranav

arma7x commented 6 years ago

Thank for update, will test it soon.

prscX commented 6 years ago

Hi @arma7x, I have also fixed itemTintColor & itemTextColor prop which was not working.

Let me know in case you face any issues.

Thanks </ Pranav >

arma7x commented 6 years ago

Thanks @prscX. Everything works.