search

prscX / react-native-bottom-action-sheet

React Native: Native Bottom Action Sheet
Apache License 2.0
634 stars 48 forks source link

GridView and SheetView callback onSelection not working #8

Closed arma7x closed 6 years ago

arma7x commented 6 years ago

https://github.com/prscX/react-native-bottom-action-sheet/blob/master/js/GridView.js#L65 https://github.com/prscX/react-native-bottom-action-sheet/blob/master/js/SheetView.js#L79

Both should be props.onSelection && props.onSelection(selection); instead of props._onSelection && props._onSelection(selection); as in READ.ME guide.

prscX commented 6 years ago

Thanks @arma7x for the raising the issue.

My Bad. Your observation is right. I will fix and push the release together with ISSUE: 7.

Thanks Pranav

prscX commented 6 years ago

Hi @arma7x, I have fixed and released V0.0.7. Can you please download latest version and verify the same.

Please let me know in case you face any issues.

Thanks </ Pranav >

arma7x commented 6 years ago

Thanks @prscX