search

prysmaticlabs / prysm

Go implementation of Ethereum proof of stake
https://www.offchainlabs.com
GNU General Public License v3.0
3.46k stars 995 forks source link

Update differences between code and help commands #14275

Closed peko-hr closed 1 month ago

peko-hr commented 2 months ago

Describe the bug

Description

https://github.com/prysmaticlabs/prysm/blob/6f7976766d23db64d5680266b542f1b531b07bc6/cmd/beacon-chain/flags/base.go#L23-L26

To make it more friendly, Value should be included. This should also be reflected in the official documentation.

🔬 Minimal Reproduction

  1. Build Prysm. (Docker is also acceptable)
  2. Show help command
  3. Check max-builder-epoch-missed-slots

Platform(s)

Linux (x86), Mac (Apple Silicon)

What version of Prysm are you running? (Which release)

v5.0.3

peko-hr commented 2 months ago

The number to be defined is 5. Is the number 5 appropriate?

https://github.com/prysmaticlabs/prysm/blob/6f7976766d23db64d5680266b542f1b531b07bc6/config/params/mainnet_config.go#L265

bnovil commented 2 months ago

Is anyone working on it ?

aminlatifi commented 1 month ago

@peko-hr it has the "Good First Issue" label, fortunately. I am a new comer like to contribute to this project, may I pick it up?

peko-hr commented 1 month ago

@aminlatifi

Of course, please. Is there anything I can do?

aminlatifi commented 1 month ago

@peko-hr My bad, it seems it's already addressed in #14334